Skip to content

TS rewrite #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Maximus7474 wants to merge 115 commits into
base: main
Choose a base branch
from
Open

TS rewrite #1

Maximus7474 wants to merge 115 commits into from
+3,583 −5,093

Conversation

@Maximus7474
Copy link
Member

@Maximus7474 Maximus7474 commented Jan 25, 2026 •
edited
Loading

As discussed a long time ago somewhere between some people and being well, bored I rewrote it in Typescript.

Server code file architecture:

  • callbacks: registering lib callbacks and parsing data to interact with DB module & managers
  • framework: main interactions with framework events & code - also includes DB module (up for debate)
  • managers: contains class based unit, call & officer manager modules
  • utils

Open for debate on writing / implementation as quite a few things were just rewritten and not analysed in depth, testing will still be done with tweaks to have the resource as "functional" as the lua build.

Structure is built on the ox_banking layout, keeping it uniform.

@Maximus7474
rm: lua files
0939b63
@Maximus7474
chore(gitignore): update
bedc630
@Maximus7474
rm: root web directory
6f94954
@Maximus7474
feat(data): config file
ea8bbf1
@Maximus7474
chore: initialize typescript project
d9713c6
@Maximus7474
feat: editorconfig
b4b5a63
@Maximus7474
feat: bun.lock
f0d03f7
@Maximus7474
chore(web): cleanup via prettier
e739b82
@Maximus7474
refactor(client/utils): serverNUiCallback
8d9f364
@Maximus7474
feat(typings): mdt types & interfaces
6f9d73d
@Maximus7474
fix(client/utils): added templating to ServerNuiCallback
3eb96a2
@Maximus7474
tweak(typings/mdt): added title to Officer type
efca6d3
@Maximus7474
feat(client): framework helper get officer title
176d097
@Maximus7474
chore(client): setup all server nui callbacks
a580faa
@Maximus7474
fix(prettierrc): removed tailwind plugin
e82d113
@Maximus7474
chore: don't track yarn installed
97ac84a
@Maximus7474
feat(server): db module
7787c08
@Maximus7474
feat(server): officer manager class
a86ffae
@Maximus7474
chore: move permissions to data/
7acaad9
@Maximus7474
feat(common): permission loader
d888e66
@Maximus7474
feat(server/framework): initialize group permissions on resource start
ea48ec1
@Maximus7474
feat(server/framework): added event listeners for ativeGroup, loaded …
f684106 
…& logout
@Maximus7474
fix(server/framework): on resource start run addOfficer on all connec…
343bfbe 
…ted players
@Maximus7474
feat(server/framework): ace permission check
65c1048
@Maximus7474
feat(server/utils): authorized callback check
81fcb5f
@Maximus7474
chore: prettier clean up
b9b5fc1
@Maximus7474
fix(typings/mdt): unit type having a number id and not string
fb3960e
@Maximus7474
fix(typings/mdt): have Units be a record and not an array
3002515
@Maximus7474
feat(server): unit manager class
8a5e02e
@Maximus7474
feat(server/unitManager): added create & update unit type methods
95dce87
@Maximus7474
fix(client/playerManager): correct grade label generation
a4122a5
@Maximus7474
feat(server/callbacks): added fetchRoster to officers module
d2df8cb
@Maximus7474
fix(server/utils): corrected auth check in callback wrapper
81acb4a
@Maximus7474
fix(server/framework): authorizedCheck not creating the permission st…
b7ae347 
…ring properly
@Maximus7474
tweak(server/utils): added dev log if no permission
2381017
@Maximus7474
feat(client/mdtState): export openMDT
481db99
@Maximus7474
fix(client/mdtState): not hiding ui when ESC is used to close MDT & c…
ee12b4c 
…lose ui on resource stop
@Maximus7474
fix(client/mdtState): private static flage messing with my brain
cd28ed1
@Maximus7474
fix(client/animManager): guess what requestAnimDict is async like int…
b04545e 
…ellisense tells you
@Maximus7474
fix(web/typings): permissions import path
432a6eb
@Maximus7474
fix(client/playerManager): private static fields messing with my brai…
00de4cc 
…n V2
@Maximus7474
fix(server/callbacks): invalid callback check for officer ser rank
5625c43
@Maximus7474
chore(client/playerManager): removed commented lua code
a14aad6
@Maximus7474
fix(web/dispatch): create unit button disabled when not in unit & has…
7adb3f6 
… perm to create
@Maximus7474
fix(server): announcements db querying & pagination
7661ea5
@Maximus7474
feat(typings/mdt): added db bolo recap
d4cc1a6
@Maximus7474
fix(server): bolo query, pagination and formatting
243e664 
-> parse json string before returning data
@Maximus7474
fix(server/callManager): wrap exports for createCall and updateCallCo…
b1d16f4 
…ords in arrow functions
@Maximus7474
fix(client/nui/mdtState): wrap openMdt export in an arrow function
b8a7c3d
@Maximus7474
fix(server/db): missing type import
ae87575
@Maximus7474
fix(server/officerManager): wrap startPositionUpdater in set immediat
f98f394
@Maximus7474
fix(server/callbacks): fix query to fire officer if player is offline
f6015be
@Maximus7474
feat(client/nui): mdt loaded state getter
14264ff
@Maximus7474
feat(client): various onNet and nui handlers that were missing
7e20461
@Maximus7474
refactor(typings): change Units to array and not record based
1479ccb 
-> maintain compatibility with UI code
@Maximus7474
chore(server/db): removed somehow duplicate/unused query wrappers
fe6213b
@Maximus7474
fix(server/db): improved search queries by formatting search value
4ed7857
@Maximus7474
chore: prettier cleanup
b9cf46b
@Maximus7474
Copy link
Member Author

Maximus7474 commented Jan 27, 2026

I think I covered most of the rewrite, there are still bugs / improvements but they mix in more with the UI, so up for debate if it's done in this PR or later on.

@Maximus7474 Maximus7474 marked this pull request as ready for review January 27, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Maximus7474